Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/55 add user sms #60

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Feature/55 add user sms #60

merged 4 commits into from
Oct 18, 2024

Conversation

jieun5119
Copy link
Collaborator

resolved : #55

๐Ÿ“Œ ๊ณผ์ œ ์„ค๋ช…

  • ํšŒ์›๊ฐ€์ž…์‹œ ๋ฌธ์ž ์ธ์ฆ์„ ํ†ตํ•œ ๋ณธ์ธ ํ™•์ธ ๊ธฐ๋Šฅ ๊ตฌํ˜„

๐Ÿ‘ฉโ€๐Ÿ’ป ์š”๊ตฌ ์‚ฌํ•ญ๊ณผ ๊ตฌํ˜„ ๋‚ด์šฉ

  • coolsms ์˜์กด์„ฑ ์ฃผ์ž…
  • ์ธ์ฆ ์ฝ”๋“œ ์ „์†ก API ๊ตฌํ˜„
  • ์ธ์ฆ ์ฝ”๋“œ ๊ฒ€์ฆ API ๊ตฌํ˜„
  • ์ธ์ฆ ์ฝ”๋“œ ์ƒ์„ฑ ๋ฐ ์œ ํšจ ๊ธฐ๊ฐ„ ๊ด€๋ฆฌ
  • ์ธ์ฆ ์‹คํŒจ ์ฒ˜๋ฆฌ ๋ฐ ์˜ค๋ฅ˜ ๋ฉ”์‹œ์ง€ ๋ฐ˜ํ™˜

โœ… ํ”ผ๋“œ๋ฐฑ ๋ฐ˜์˜์‚ฌํ•ญ

โœ… PR ํฌ์ธํŠธ & ๊ถ๊ธˆํ•œ ์ 

  • ๊ถ๊ธˆํ•œ ์ ์ด๋‚˜ ๋ถ€์กฑํ•œ ๋ถ€๋ถ„ ๋ง์”€ํ•ด์ฃผ์‹œ๋ฉด ๋ฐ˜์˜ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค. ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค.

@jieun5119 jieun5119 added โœจ Feature ๊ธฐ๋Šฅ ๊ฐœ๋ฐœ ์ง€์€ labels Oct 10, 2024
@jieun5119 jieun5119 linked an issue Oct 10, 2024 that may be closed by this pull request
[FEATURE] ํšŒ์›๊ฐ€์ž… ์‹œ ๋ฌธ์ž ์ธ์ฆ ๊ตฌํ˜„ #55
Closed
4 tasks
@7zrv 7zrv self-requested a review October 10, 2024 07:34
Leehunil
Leehunil approved these changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@Leehunil Leehunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ธ์ฆ ์ฝ”๋“œ ์ €์žฅ์„ Redis๋ฅผ ์‚ฌ์šฉํ•˜์‹  ๊ฑฐ ๋งž๋‚˜์š”..?? ์•ˆ ์ ํ˜€ ์žˆ์–ด์„œ ์—ฌ์ญค ๋ด…๋‹ˆ๋‹ค... ์ธ์ฆ ์ฝ”๋“œ๋ฅผ Redis๋กœ ๊ด€๋ฆฌํ•˜๋‹ˆ๊น ๋” ํŽธ๋ฆฌํ•˜๊ฒŒ ๊ด€๋ฆฌํ•  ์ˆ˜ ์žˆ๊ฒ ๋„ค์š”!!

@jieun5119
Copy link
Collaborator Author

๋„ค, ๋งž์Šต๋‹ˆ๋‹ค! ์งง์€ ๊ธฐ๊ฐ„ ๋™์•ˆ๋งŒ ์œ ์ง€ํ•ด์•ผ ํ•˜๋Š” ๋ฐ์ดํ„ฐ์ด๊ธฐ ๋•Œ๋ฌธ์— RDB๋ณด๋‹ค๋Š” Redis๊ฐ€ ๋” ์ ํ•ฉํ•˜๋‹ค๊ณ  ํŒ๋‹จํ•ด์„œ Redis๋ฅผ ์‚ฌ์šฉํ–ˆ์Šต๋‹ˆ๋‹ค.

@jieun5119
๋ฌธ์ž์ธ์ฆ ์˜์กด์„ฑ ์ถ”๊ฐ€
3d10880
@jieun5119
feat: ํšŒ์›๊ฐ€์ž…์‹œ ๋ฌธ์ž์ธ์ฆ ๊ธฐ๋Šฅ ๊ตฌํ˜„
0f13f24 
- ํšŒ์›๊ฐ€์ž…์‹œ ์‚ฌ์šฉ์ž ๋ฒˆํ˜ธ๋กœ ๋ฌธ์ž ์ „์†ก ๊ธฐ๋Šฅ

- ์ธ์ฆ๋ฒˆํ˜ธ ์ž…๋ ฅ์‹œ ๊ฒ€์ฆ ํ›„ ๊ฐ€์ž…

- ์ „ํ™”๋ฒˆํ˜ธ ์ค‘๋ณต์—ฌ๋ถ€ ๊ฒ€์‚ฌ

- ์ธ์ฆ๋ฒˆํ˜ธ ๋งŒ๋ฃŒ ์‹œ๊ฐ„ ์„ค์ •
@jieun5119
-fix: SecureRandom์„ ์‚ฌ์šฉํ•œ ๋‚œ์ˆ˜์ƒ์„ฑ์œผ๋กœ ์ˆ˜์ •
d30c357
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 18, 2024

Quality Gate Passed Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
8.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jieun5119 jieun5119 merged commit 086ed84 into develop Oct 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l2yujw l2yujw l2yujw approved these changes

@7zrv 7zrv 7zrv approved these changes

@Leehunil Leehunil Leehunil approved these changes

Assignees
No one assigned
Labels
โœจ Feature ๊ธฐ๋Šฅ ๊ฐœ๋ฐœ ์ง€์€
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] ํšŒ์›๊ฐ€์ž… ์‹œ ๋ฌธ์ž ์ธ์ฆ ๊ตฌํ˜„
4 participants
@jieun5119 @l2yujw @7zrv @Leehunil